IntellectualSites / IntellectualSites/PlotSquared

[V6] "use" flag prevents too many interactions

Open
#3,112 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Enhancement Low Priority
Dominant language
Java
Stars
653
Forks
975
Avg merge
2m
Merged PRs (30d)
6

Description

Server Implementation

Paper

Server Version

1.16.5

Describe the bug

Players can't use (via right-clicking) items they are holding while looking at a block that isn't explicitly added to a plot's "use" flag (unless they are added to the plot of course).

It seems as though the entire right-click process is being cancelled, which results in the cancellation of fairly normal actions that are done via right-clicking such as equipping a piece of armour, firing a bow, throwing an ender pearl (or other projectile), charging a crossbow, using a fishing rod, etc. if the player happens to be looking at a block that isn't added to the plot's "use" flag.

I'm not 100% sure if this is even possible to prevent. If that's the case, could a configuration option possibly be added to disable the "use" flag entirely?

To Reproduce
  1. Set up a plot world
  2. Have a player go into a plot they are not added to or the road and look at a block that isn't added to the "use" flag
  3. Have them right-click-equip a piece of armour (or do any of the examples in the "Describe the bug" section) while looking at the block, and observe as it gets cancelled
Expected behaviour

Any behaviour that could occur related the block upon right-clicking it should be cancelled, but other things like equipping armour shouldn't.

Screenshots / Videos

No response

Error log (if applicable)

No response

Plot Debugpaste

https://athion.net/ISPaster/paste/view/c06fb3932d4446e99b63c0627b78f4ca

PlotSquared Version

6.0.0-Premium

Checklist
Anything else?

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reported right-click cases in a plot world using the listed PlotSquared 6.0.0-Premium and Paper 1.16.5 context. Compare behavior while looking at a block outside the plot’s "use" flag with the expected result: block interaction should be cancelled without cancelling item actions such as equipping armor or using projectiles.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.