IntellectualSites / IntellectualSites/PlotSquared
Make the "PvP" flag encompass reeling in players with a fishing rod
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 653
- Forks
- 975
- Avg merge
- 2m
- Merged PRs (30d)
- 6
Description
What feature do you want to see added?
I, and I'm sure others upon realising, am not happy with the fact that players can use fishing rods to pull other players around and annoy them. Similar to how WorldGuard already does it, the "PvP" flag being set to "false" should cancel PlayerFishEvent when its State is CAUGHT_ENTITY, and said entity is a Player.
Are there any alternatives?
You can do this already by utilising WorldGuard's global region and setting its own PvP flag to "deny", but we shouldn't have to use WorldGuard flags in our plot worlds.
Anything else?
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the handler for the PvP flag and the code that processes PlayerFishEvent. Check how the flag is applied to player interactions, then verify the CAUGHT_ENTITY case when the caught entity is a Player. Done means PvP=false prevents the fishing-rod pull while other fishing behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- game-dev
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100