IntellectualSites / IntellectualSites/PlotSquared

after plot-merge: all signs deleted or wrong sign-location

Open
#3,007 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Approved Bug Low Priority
Dominant language
Java
Stars
653
Forks
975
Avg merge
2m
Merged PRs (30d)
6

Description

Server Implementation

Paper

Server Version

1.16.5

Describe the bug

It's still a problem with plot-merge at now. But not with unmerge! And at this time we haven't 2 or more signs at one merged plot like earlier.

For example, we have 4 plots. And one owner. After all follow steps we use "/p unmerge"!

2020-05-19_02 00 13

Situation A:

the owner standing on plot 1 and looking to plot 2 (east)
= PS "remove all signs" and "set" the new plot-sign on the left top side -->OK

Situation B:

the owner standing on plot 2 and looking to plot 1 (west)
= the plugin down't break the sign on the plot where the player standing on (the problem behind all)

2020-05-19_02 09 06

Situation C:

the owner standing on plot 2 and looking to plot 3 (south)
= PS "remove all signs" and "set" the new plot-sign on the left top side -->OK

Situation D:

the owner standing on plot 3 and looking to plot 2 (north)
= PS "remove all signs" and "set" the new plot-sign on the old path ... and then PS delete all paths in the plot --> this merged plot hasn't a sign.

2020-05-19_02 18 56

I hope this was understandable with this step-by-step tutorial at now. :)

tested with PlotSquared (premium) 5.11.1 + 1.15.2 PaperSpigot 300

To Reproduce

See picture and follow the steps. Replicable with the merge command.

Expected behaviour

one signs for one merged plot

Screenshots / Videos

see description

Error log (if applicable)

No response

Plot Debugpaste

if it's needed, I can link an newer debug report with an newer test

PlotSquared Version

last tested with 5.11.1

Checklist
Anything else?

no "/plot debugpaste" needed, but I can add it with an newer test

Copy of YouTrack

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported /plot merge and /p unmerge cases with four adjacent plots, following the directional situations in the issue and checking sign and path locations. Done means merged plots retain exactly one correctly located sign in every direction, without deleting the wrong sign or paths unexpectedly.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.