IntellectualSites / IntellectualSites/FastAsyncWorldEdit
Reduce diff between FAWE PaperweightAdapter and WE PaperweightAdapter classes
Open
Nobody has claimed this yet.
Good first issue
help wanted
- Dominant language
- Java
- Stars
- 806
- Forks
- 394
- Avg merge
- 22h 19m
- Merged PRs (30d)
- 14
Description
To make porting easier, we should try to minimize the diff between WE PaperweightAdapter and our changes on top of it.
That means:
- Figure out the reason for our changes
- If they improve something and apply to WE too, consider upstreaming
- If they do not improve something, get rid of them
- If they are specific to FAWE, try moving them to the PaperweightFaweAdapter subclass
- Otherwise, properly document why this change is needed
This can be done in multiple steps, looking at small parts only.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the FAWE PaperweightAdapter and WE PaperweightAdapter classes, then trace the reason for each difference before changing it. For each change, determine whether it should be upstreamed, removed, moved to PaperweightFaweAdapter, or documented; complete a small part at a time and leave the adapters with a smaller, justified diff.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100