IntellectualSites / IntellectualSites/FastAsyncWorldEdit

Formatting codes in expressions within //calc and //gen affect chat message formatting

Open
#3,436 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Requires Testing
Dominant language
Java
Stars
806
Forks
394
Avg merge
22h 19m
Merged PRs (30d)
14

Description

Server Implementation

Paper

Server Version

1.21.10

Describe the bug

If an expression has formatting codes within it; the messages sent in chat parses the formatting codes as well.
This seems to work with //calc and //gen, though I'm not aware if there are other commands that can have this same problem.

To Reproduce
  1. Run //calc with formatting code(s) somewhere within it, it does not matter whether it parses or not. e.g. //calc true&&false or //calc &e

OR

  1. Create a valid selection
  2. Run //gen with an invalid expression with formatting code(s) in the expression parameter. e.g. //gen stone &1
Expected behaviour

The formatting codes should affect the formatting of the chat message; showing up the same as other text.

Screenshots / Videos
Image

Commands executed were:
//calc true&&false, //calc &e, and //gen stone &1

Error log (if applicable)

No response

Fawe Debugpaste

https://intellectualsites.gitbook.io/fastasyncworldedit/command-utilities/masks

Are you interested in contributing a fix?

No

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the //calc and //gen command handlers and the code that formats their chat responses, using the reproduction commands in the issue. Check how formatting codes inside expression arguments are handled compared with ordinary text. Done means those codes are displayed consistently with other chat text for both valid and invalid expressions.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.