IntellectualSites / IntellectualSites/FastAsyncWorldEdit
Server-Crash on FAWE-Operation while affected Blocks are getting ticked
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 806
- Forks
- 394
- Avg merge
- 22h 19m
- Merged PRs (30d)
- 14
Description
Server Implementation
Paper
Server Version
1.21.1
Describe the bug
If you were to remove or even change blocks which seem to try to update their neighbours, which are also getting removed by an operation, e.g. //air, there are chances the server will crash, with an Exception while updating neighbours-Error.
This also seems to be in direct connection with a PlotSquared Bug, as the error is basically the same, and from my understanding (this may be wrong), if FAWE is installed on the server with PS, it will be used, e.g. to delete plots.
https://github.com/IntellectualSites/PlotSquared/issues/4337
To Reproduce
- Create an area of e.g. Sculk Sensors, with a layer of Trapdoors on top, stack it horizontally, e.g. to create a rectangle
- Select the entire region with the sculk sensors and trapdoors
- Trigger the sculk sensors by walking on top of the trapdoors
- Remove the area while the sculk sensors / trapdoors are still triggering the neighbour blocks, e.g. via
//air - If nothing happens, repeat
Expected behaviour
The server should continue working, and the blocks should have all been removed, without any crash.
Screenshots / Videos
Error log (if applicable)
https://gist.github.com/gamecrash534/f136283f2a55884c850e5f8acdb2c083
Fawe Debugpaste
https://athion.net/ISPaster/paste/view/fec39af532b64718bb62e49b5cc5971c
Fawe Version
FastAsyncWorldEdit version 2.13.1-SNAPSHOT-1065;cca3b71
Checklist
- I have included a Fawe debugpaste.
- I am using the newest build from https://ci.athion.net/job/FastAsyncWorldEdit/ and the issue still persists.
Anything else?
Sorry, if the description is a bit inaccurate. I couldn't really think of anything else ;)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Sculk Sensor and Trapdoor setup on Paper 1.21.1, then inspect the linked error log and FAWE debugpaste. Compare the failure with PlotSquared issue 4337; done means the //air operation removes the affected blocks without an Exception while updating neighbours or a server crash.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend, game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100