IntellectualSites / IntellectualSites/FastAsyncWorldEdit
Commands using Selections now require Confirm label
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 806
- Forks
- 394
- Avg merge
- 22h 19m
- Merged PRs (30d)
- 14
Description
Server Implementation
Paper
Server Version
1.20.4
Describe the bug
Changes in #3052 now require commands using selections to include @Confirm(Confirm.Processor.REGION). Not having this gives a pretty unfriendly error:
Previously you would just get the regular informative error:
I have tested adding the annotation to one command and it doesn't appear to cause issues with regular WorldEdit, so the change doesn't cause any compatibility issues.
To Reproduce
- Create a command which takes a Selection
- Do not add the Confirm annotation
- Run the command ingame without an active selection
- IllegalStateException error
Expected behaviour
Commands expecting a selection which do not recieve one should error instructively as before:
Effectively, when no @Confirm(...) is present for the region, Confirm.Processor.REGION should be the default.
Screenshots / Videos
No response
Error log (if applicable)
No response
Fawe Debugpaste
https://athion.net/ISPaster/paste/view/d8e209464d4e4bcd85aec7766117481f
Fawe Version
FastAsyncWorldEdit-Bukkit-2.12.4-SNAPSHOT-1020
Checklist
- I have included a Fawe debugpaste.
- I am using the newest build from https://ci.athion.net/job/FastAsyncWorldEdit/ and the issue still persists.
Anything else?
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the selection-command changes in #3052 and reproduce the issue with a command that takes a Selection but has no @Confirm annotation. Verify that running it without an active selection produces the regular informative error rather than an IllegalStateException, while commands with explicit confirmation continue to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100