IntellectualSites / IntellectualSites/FastAsyncWorldEdit

Commands using Selections now require Confirm label

Open
#3,077 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Requires Testing
Dominant language
Java
Stars
806
Forks
394
Avg merge
22h 19m
Merged PRs (30d)
14

Description

Server Implementation

Paper

Server Version

1.20.4

Describe the bug

Changes in #3052 now require commands using selections to include @Confirm(Confirm.Processor.REGION). Not having this gives a pretty unfriendly error:

image

Previously you would just get the regular informative error:

image

I have tested adding the annotation to one command and it doesn't appear to cause issues with regular WorldEdit, so the change doesn't cause any compatibility issues.

To Reproduce
  1. Create a command which takes a Selection
  2. Do not add the Confirm annotation
  3. Run the command ingame without an active selection
  4. IllegalStateException error
Expected behaviour

Commands expecting a selection which do not recieve one should error instructively as before:
image

Effectively, when no @Confirm(...) is present for the region, Confirm.Processor.REGION should be the default.

Screenshots / Videos

No response

Error log (if applicable)

No response

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/d8e209464d4e4bcd85aec7766117481f

Fawe Version

FastAsyncWorldEdit-Bukkit-2.12.4-SNAPSHOT-1020

Checklist
Anything else?

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the selection-command changes in #3052 and reproduce the issue with a command that takes a Selection but has no @Confirm annotation. Verify that running it without an active selection produces the regular informative error rather than an IllegalStateException, while commands with explicit confirmation continue to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.