IntellectualSites / IntellectualSites/FastAsyncWorldEdit

Wand item set to -1 causes NoMatchException

Open
#2,930 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Approved Bug
Dominant language
Java
Stars
806
Forks
394
Avg merge
22h 19m
Merged PRs (30d)
14

Description

Server Implementation

Paper

Server Version

1.21

Describe the bug

-1 is a valid item in the original WorldEdit to say "no default item please". FAWE doesn't recognize it as such and it errors out instead.

To Reproduce
  1. Set 'wand-item' to -1 to disable the wand item.
  2. Observe console error
Expected behaviour

FAWE should not error out.

Screenshots / Videos
Debug log (inlined) 
[16:52:18 WARN]: com.sk89q.worldedit.extension.input.NoMatchException: Item name '-1' was not recognized.
[16:52:18 WARN]:        at FastAsyncWorldEdit-Bukkit-2.11.2.jar//com.sk89q.worldedit.extension.factory.parser.DefaultItemParser.parseFromInput(DefaultItemParser.java:126)
[16:52:18 WARN]:        at FastAsyncWorldEdit-Bukkit-2.11.2.jar//com.sk89q.worldedit.extension.factory.parser.DefaultItemParser.parseFromInput(DefaultItemParser.java:47)
[16:52:18 WARN]:        at FastAsyncWorldEdit-Bukkit-2.11.2.jar//com.sk89q.worldedit.extension.factory.ItemFactory.parseFromInput(ItemFactory.java:50)
[16:52:18 WARN]:        at FastAsyncWorldEdit-Bukkit-2.11.2.jar//com.sk89q.worldedit.LocalSession.loadDefaults(LocalSession.java:1262)
[16:52:18 WARN]:        at FastAsyncWorldEdit-Bukkit-2.11.2.jar//com.sk89q.worldedit.LocalSession.getTool(LocalSession.java:1234)
[16:52:18 WARN]:        at FastAsyncWorldEdit-Bukkit-2.11.2.jar//com.sk89q.worldedit.extension.platform.PlatformManager.handleBlockInteract(PlatformManager.java:433)
[16:52:18 WARN]:        at FastAsyncWorldEdit-Bukkit-2.11.2.jar//com.sk89q.worldedit.util.eventbus.MethodHandleEventHandler.dispatch(MethodHandleEventHandler.java:51)
[16:52:18 WARN]:        at FastAsyncWorldEdit-Bukkit-2.11.2.jar//com.sk89q.worldedit.util.eventbus.EventHandler.handleEvent(EventHandler.java:73)
[16:52:18 WARN]:        at FastAsyncWorldEdit-Bukkit-2.11.2.jar//com.sk89q.worldedit.util.eventbus.EventBus.dispatch(EventBus.java:193)
[16:52:18 WARN]:        at FastAsyncWorldEdit-Bukkit-2.11.2.jar//com.sk89q.worldedit.util.eventbus.EventBus.post(EventBus.java:181)
[16:52:18 WARN]:        at FastAsyncWorldEdit-Bukkit-2.11.2.jar//com.sk89q.worldedit.WorldEdit.handleBlockRightClick(WorldEdit.java:791)
[16:52:18 WARN]:        at FastAsyncWorldEdit-Bukkit-2.11.2.jar//com.sk89q.worldedit.bukkit.WorldEditListener.onPlayerInteract(WorldEditListener.java:168)
[16:52:18 WARN]:        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor23.execute(Unknown Source)
[16:52:18 WARN]:        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77)
[16:52:18 WARN]:        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80)
[16:52:18 WARN]:        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70)
[16:52:18 WARN]:        at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54)
[16:52:18 WARN]:        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:131)
[16:52:18 WARN]:        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:628)
[16:52:18 WARN]:        at org.bukkit.craftbukkit.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:604)
[16:52:18 WARN]:        at net.minecraft.server.level.ServerPlayerGameMode.useItemOn(ServerPlayerGameMode.java:536)
[16:52:18 WARN]:        at net.minecraft.server.network.ServerGamePacketListenerImpl.handleUseItemOn(ServerGamePacketListenerImpl.java:1942)
[16:52:18 WARN]:        at net.minecraft.network.protocol.game.ServerboundUseItemOnPacket.handle(ServerboundUseItemOnPacket.java:44)
[16:52:18 WARN]:        at net.minecraft.network.protocol.game.ServerboundUseItemOnPacket.handle(ServerboundUseItemOnPacket.java:11)
[16:52:18 WARN]:        at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:56)
[16:52:18 WARN]:        at net.minecraft.server.TickTask.run(TickTask.java:18)
[16:52:18 WARN]:        at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:151)
[16:52:18 WARN]:        at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24)
[16:52:18 WARN]:        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1537)
[16:52:18 WARN]:        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:201)
[16:52:18 WARN]:        at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:125)
[16:52:18 WARN]:        at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1514)
[16:52:18 WARN]:        at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1507)
[16:52:18 WARN]:        at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:135)
[16:52:18 WARN]:        at net.minecraft.server.MinecraftServer.managedBlock(MinecraftServer.java:1466)
[16:52:18 WARN]:        at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1588)
[16:52:18 WARN]:        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1304)
[16:52:18 WARN]:        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:330)
[16:52:18 WARN]:        at java.base/java.lang.Thread.run(Unknown Source)
Error log (if applicable)

No response

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/74552b40a78a4e91855de706acac4e6a

Fawe Version

FastAsyncWorldEdit version 2.11.2

Checklist
Anything else?

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with DefaultItemParser.java at parseFromInput and trace how LocalSession.loadDefaults handles the wand-item setting. Reproduce with wand-item set to -1 on Paper 1.21, then verify that startup or interaction no longer logs NoMatchException and that the wand item remains disabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.