IntellectualSites / IntellectualSites/FastAsyncWorldEdit

Instantiation of convex polyhedral region seems to not work sometimes

Open
#2,805 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting Response Requires Testing
Dominant language
Java
Stars
806
Forks
394
Avg merge
22h 19m
Merged PRs (30d)
14

Description

Server Implementation

Paper

Server Version

1.20.5/6

Describe the bug

I'm not sure what's causing said bug, but as stated in the title, sometimes when instantiating a convex polyhedral region, and then using said region in an EditSession or something (I used EditSession#setBlocks), the blocks aren't properly modified. This is because the region, while it has all its vertices, doesnt have all the blocks that it should have - see this (me discussing the issue on Discord) for more info.

To Reproduce
  1. Try to instantiate 2 convex polyhedral regions back to back.
Expected behaviour

It should populate the region with all the blocks, instead of just the vertices.

Screenshots / Videos

image

I know this doesn't show much, nor is it easy to see really, but this is the same screenshot I put in the Discord when discussing it. Check the link above that goes to the Discord for more context here.

Error log (if applicable)

No response

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/58227cfeef4043b6a7d26f1dd759d9b2

Fawe Version

FastAsyncWorldEdit version 2.10.1-SNAPSHOT-778;c77d341

Checklist
Anything else?

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported case on Paper 1.20.5/6 with two convex polyhedral regions instantiated back to back, then used with EditSession#setBlocks. Use the linked FAWE debugpaste and Discord discussion for context; done means the region contains all expected blocks rather than only its vertices.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.