IntellectualSites / IntellectualSites/FastAsyncWorldEdit

Rotating schematics creates messed up results

Open
#2,741 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Approved Bug
Dominant language
Java
Stars
806
Forks
394
Avg merge
22h 19m
Merged PRs (30d)
14

Description

Server Implementation

Paper

Server Version

1.20.5/6

Describe the bug

Whenever you rotate schematics with a different angle than the standard 90, 180, 270, 360 degrees, the result is completely messed creating weird shapes.
I know that WorldEdit doesn't recommend to use other angles than 90 but with normal WorldEdit rotation works mostly fine with just a few missing blocks at certain angles here and there. FastAsyncWorldEdit completely messes up the shapes though creating a result that is impossible to work with.

Here I pasted a sample lantern schematic so you can better see the issues that appear with FastAsyncWorldEdit at anything other than 90 degrees even 45.
With WorldEdit everything works as expected no matter which version you choose from 1.12 till latest version.

WorldEdit Result (everything fine):
2024-05-17_15 25 23

FastAsyncWorldEdit (messed up):
2024-05-17_15 34 58

Here you can see that any angle other than the 90s create unexpected results. Sometimes the lamp stand appears twice, sometimes the entire lamp is cut off. Its also weird that there doesn't seem to be a clear pattern in this behavior.
The lamp was copied at the bottom of the lamp stand so the rotation should be alright as visible in the WorldEdit screenshot.

To Reproduce
  1. Load a schematic with //schem load streetlamp (Get sample streetlamp schematic here)
  2. Rotate the schematic with //rotate 45
  3. Paste the schematic with //paste
Expected behaviour

When pasting the schematic the result should look similar to WorldEdit and not messed up.

Screenshots / Videos

No response

Error log (if applicable)

No response

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/8e010b08548142cd9e61cf3a4873d7d8

Fawe Version

FastAsyncWorldEdit version 2.10.1-SNAPSHOT-776;3dc949e

Checklist
Anything else?

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the linked streetlamp schematic using //schem load streetlamp, //rotate 45, and //paste, then review the provided FAWE debugpaste and compare the result with WorldEdit. Done means non-right-angle rotations produce a usable shape without duplicated or missing sections, matching the expected WorldEdit behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.