IntellectualSites / IntellectualSites/FastAsyncWorldEdit

Remove alpha option, or repurpose it as a "strength" on #saturate pattern

Open
#2,430 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Enhancement
Dominant language
Java
Stars
806
Forks
394
Avg merge
22h 19m
Merged PRs (30d)
14

Description

Server Implementation

Paper

Server Version

1.20.1

Describe the bug

Due to a player request, @TheMeinerLP and I investigated how #saturate works and found out that the alpha (which is the tranparency) always has to be 255 in order to work.

To Reproduce
  1. Do //re #saturate[0][255][0][1] and set the 1 to a number that is not 255 and below
  2. See after a minute that it won't work
Expected behaviour

It should work and the transparency should be applied -> glass might be set then or something more transparent

Screenshots / Videos

No response

Error log (if applicable)

None

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/4a7ba67d0e8347b9ae6d553dd08ff988

Fawe Version

Is not important here, see info below (we had several tests running at this version and latest 2.7.2)

Checklist
Anything else?

This issue is since 2021 in the code at this place:
https://pastebin.com/HK9giLqt

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with //re #saturate[0][255][0][1], then review the saturate implementation described in the linked Pastebin. Determine whether alpha should be removed or repurposed as strength, and verify the chosen behavior by confirming that values below 255 work as intended.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.