IntellectualSites / IntellectualSites/FastAsyncWorldEdit
Remove alpha option, or repurpose it as a "strength" on #saturate pattern
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 806
- Forks
- 394
- Avg merge
- 22h 19m
- Merged PRs (30d)
- 14
Description
Server Implementation
Paper
Server Version
1.20.1
Describe the bug
Due to a player request, @TheMeinerLP and I investigated how #saturate works and found out that the alpha (which is the tranparency) always has to be 255 in order to work.
To Reproduce
- Do //re #saturate[0][255][0][1] and set the 1 to a number that is not 255 and below
- See after a minute that it won't work
Expected behaviour
It should work and the transparency should be applied -> glass might be set then or something more transparent
Screenshots / Videos
No response
Error log (if applicable)
None
Fawe Debugpaste
https://athion.net/ISPaster/paste/view/4a7ba67d0e8347b9ae6d553dd08ff988
Fawe Version
Is not important here, see info below (we had several tests running at this version and latest 2.7.2)
Checklist
- I have included a Fawe debugpaste.
- I am using the newest build from https://ci.athion.net/job/FastAsyncWorldEdit/ and the issue still persists.
Anything else?
This issue is since 2021 in the code at this place:
https://pastebin.com/HK9giLqt
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with //re #saturate[0][255][0][1], then review the saturate implementation described in the linked Pastebin. Determine whether alpha should be removed or repurposed as strength, and verify the chosen behavior by confirming that values below 255 work as intended.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100