IntelLabs / IntelLabs/vdms

Autroeplicate backup_flag doesn't do anything despite being documented

Open
#186 0 comments 0 reactions 0 assignees View on GitHub
Bug Priority: Backlog
Dominant language
C++
Stars
93
Forks
34
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**

The autoreplicate backup flag [described here](https://github.com/intel-innersource/libraries.databases.visual.vdms/wiki/VDMS-Backup-and-Restoring-Options) does not appear to actually do anything.

**To Reproduce**
The only location i was able to find the backup_flag used is in QueryHandlerPmgd.cc and server.cc, where it doesnt enable or disable anything, it just seems to be copied as a part of the backup run or put into the configuration structure.

**Expected behavior**

This should enable/disable the backup option, or we should remove it and remove it from documentation. Given there is a default value (or magic number in config) that also disables its functionality we may want to consider just removing it, or doing some updates internally such that the replicate value is set to -1 if we see the backup flag is set to false.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.