IntelLabs / IntelLabs/atlas-cli

Refactor manifest generation

Open
#72 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
22
Forks
4
Avg merge
1d 14h
Merged PRs (30d)
2

Description

There's significant duplication between create_manifest and create_oms_manifest. Both functions share manifest creation and cross-reference logic. We could add task to refactor it.
```
enum ManifestFormat {
Standalone,
OMS,
// Future formats...
}

impl ManifestFormat {
fn create(&self, config: ManifestCreationConfig) -> Result<()> {
match self {
Self::Standalone => create_c2pa_manifest(config),
Self::OMS => create_oms_manifest(config),
}
}
}
```

_Originally posted by @sandlbn in https://github.com/IntelLabs/atlas-cli/pull/54#pullrequestreview-3169364368_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.