Instagram / Instagram/IGListKit

Automate PR checking with Danger

Open
#394 24 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Objective-C
Stars
13.1k
Forks
1.5k
PR merge metrics
No merged PRs in 30d

Description

http://danger.systems/ cc @orta

### Warnings

- [ ] Non-final class in examples
- [x] [Swiftlint](https://github.com/ashfurrow/danger-swiftlint) for examples
- [ ] Markdown verification using [prose](https://github.com/dbgrandi/danger-prose) (incl. link checking)
- [ ] ObjC classes without `IG_SUBCLASSING_RESTRICTED`
- [x] ~Big PR~
- [x] ~No CHANGELOG.md entry for any change~

### Failures

- [ ] New CHANGELOG.md entry when `.h` file is changed
- [ ] Facebook copyright in headers
- [ ] Changes to restricted file types (`.lock`, `.xcconfig`, etc)
- [ ] **Always fail**: "Merging should be done internally"
- [x] ~Only allow editing `/docs` from admins~
- [x] ~WIP pull requests~

Any other ideas?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.