InsightSoftwareConsortium / InsightSoftwareConsortium/LesionSizingToolkit

Refactor the module

Open
#22 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
C++
Stars
10
Forks
13
PR merge metrics
No merged PRs in 30d

Description

As @dzenanz pointed in #20 , the module needs to be refactored. Some classes seem to be specialized versions of classes that exist in the toolkit (Canny detection filters, morphological filters, etc.), but it should be investigated whether better inheritance can be achieved.

Some minor issues related to the refactoring, or which could be done while refactoring are:
- Separate the class header from the implementation (e.g. see [itk::DescoteauxSheetnessImageFilter](https://github.com/InsightSoftwareConsortium/LesionSizingToolkit/blob/master/include/itkDescoteauxSheetnessImageFilter.h)).
- Provide *Set* / *Get* methods using ITK macros for all ivars.
- Provide some default values for ivars (e.g. see [itk::DescoteauxSheetnessImageFilter](https://github.com/InsightSoftwareConsortium/LesionSizingToolkit/blob/master/include/itkDescoteauxSheetnessImageFilter.h)).
- Provide the implementation for the `PrintSelf` method in cases which is missing or incomplete.

- Prefer initialization lists over assignment.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.