InsightSoftwareConsortium / InsightSoftwareConsortium/ITK
Strange "ignoring non-DICOM and non-ITK standard keys = ITK_original_direction, ITK_original_spacing" log
- Dominant language
- C++
- Stars
- 1.7k
- Forks
- 748
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 64
Description
The recent DICOM changes (https://github.com/InsightSoftwareConsortium/ITK/issues/6467 , https://github.com/InsightSoftwareConsortium/ITK/issues/6468 , https://github.com/InsightSoftwareConsortium/ITK/pull/6469) have broken some of my app's unit tests, and I'm investigating that...
One thing I see logged is:
`ignoring non-DICOM and non-ITK standard keys = ITK_original_direction, ITK_original_spacing`
This message strikes me as odd, because `ITK_original_direction` and `ITK_original_spacing` certainly seem to be "ITK standard keys", [they are still there in main branch](https://github.com/InsightSoftwareConsortium/ITK/blob/0ae23ea4ce57275cb7f174f8637de86af9397864/Modules/IO/ImageBase/include/itkImageFileReader.hxx#L221).
Contributor guide
Research direction
Start with Modules/IO/ImageBase/include/itkImageFileReader.hxx around line 221 and compare the recent DICOM changes referenced in issues 6467 and 6468 and pull request 6469. Determine why ITK_original_direction and ITK_original_spacing are reported as non-standard keys, then confirm the logging or classification behaves correctly in the affected unit tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100