InsightSoftwareConsortium / InsightSoftwareConsortium/ITK

Raise `cmake_minimum_required` in remote modules

Open
#4,761 1 comment 1 reaction 0 assignees View on GitHub
type:Infrastructure
Dominant language
C++
Stars
1.7k
Forks
748
Avg merge
1d 1h
Merged PRs (30d)
64

Description

### Description

The dashboard is displaying configure warnings related to the `cmake_minimum_required` version value in remote modules, e.g.
https://open.cdash.org/builds/9713834/configure
https://open.cdash.org/builds/9713631/configure
https://open.cdash.org/builds/9716262/configure

It needs to be updated to 3.16.3 to be up-to-date with ITK, i.e.
https://github.com/InsightSoftwareConsortium/ITK/blob/1381ec4c18585ac0e8bdbd580b7b34c0bed9e0d1/CMakeLists.txt#L15
https://github.com/InsightSoftwareConsortium/ITK/blob/1381ec4c18585ac0e8bdbd580b7b34c0bed9e0d1/CMake/ITKModuleExternal.cmake#L13

### Impact analysis

Remotes are being packaged with configure warnings.

### Expected behavior

No configure warnings are raised.

### Actual behavior

Configure warnings are present.

### Versions

All `HEAD` versions of remotes.

### Environment

N/A.

### Additional Information

Identified while inspecting the dashboard from builds triggered by the changes in issue #4748.

Unfortunately, the **GitHub action builds are not reporting these warnings as failures**, and thus they may go unnoticed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.