InsightSoftwareConsortium / InsightSoftwareConsortium/ITK

ITK Build/Testing/Coverage doesn't check if modified code is ever exercised in a PR

Open
#4,223 2 comments 0 reactions 0 assignees View on GitHub
type:Bug
Dominant language
C++
Stars
1.7k
Forks
748
Avg merge
1d 1h
Merged PRs (30d)
64

Description

In #4175 code changes were made on a set of tests which were not part of the default ITK build.

As a result testing never was actually executed on the changes, resulting in the committing of broken code. (The tests were already broken it turned out, but for a different reason before the code change).

The Build/Coverage/Test infrastructure should try to infer whether the code is ever actually used and warn about this.

CC @dzenanz

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.