InsightSoftwareConsortium / InsightSoftwareConsortium/ITK
Compiling `DCMTK` shows a Mac file format warning for `arith.h`
- Dominant language
- C++
- Stars
- 1.7k
- Forks
- 748
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 64
Description
### Description
When compiling ITK with the `IODCMTK` third-party module, the compiler shows a warning saying that the file
`config/include/dcmtk/config/arith.h` is generated with Mac file format, and that it should be converted to DOS/UNIX format.
### Steps to Reproduce
Clone ITK at the specified commit (or `master`) and compile with `Module_ITKIODCMTK` set to `ON`.
### Expected behavior
No warnings when compiling.
### Actual behavior
`config/include/dcmtk/config/arith.h` is generated with Mac file format.
```
itk-Bin/Modules/ThirdParty/DCMTK/ITKDCMTK_ExtProject-build/config/include/dcmtk/config/arith.h(1,1):
warning C4335: Mac file format detected: please convert the source file to either DOS or UNIX format
```
### Reproducibility
100%
### Versions
ITK `master` at commit 69b7c4ef036ce36b32ace738db111d3d4720dbe4
### Environment
OS: Windows 10
CMake: 3.20.3
Compiler: MSVC 2019 19.29.30133.0
### Additional Information
Compiling the `DCMTK` library as a separate/system project [at the pointed tip](https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/ThirdParty/DCMTK/DCMTKGitTag.cmake#L22) shows the same warnings.
I tried to find where in the upstream repository the `arith.h` file is generated. It looks like it is here:
https://github.com/InsightSoftwareConsortium/DCMTK/blob/master/config/Makefile.in
But I did not find why a Mac format file is being generated.
I also see that the `DCMTK` version used by `ITK` is quite behind the upstream version.
Contributor guide
Assessment
This issue has not been assessed yet.