InsightSoftwareConsortium / InsightSoftwareConsortium/ITK
[ITK 5.1] Build failure in release builds due to double-conversion linkage
- Dominant language
- C++
- Stars
- 1.7k
- Forks
- 748
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 64
Description
### Description
In
https://github.com/InsightSoftwareConsortium/ITK/blob/7900a8b6d63ec8201405eff3b46c8d2a4e563c45/Modules/ThirdParty/DoubleConversion/CMakeLists.txt#L9-L13
` get_target_property(ITKDoubleConversion_LIBRARIES double-conversion::double-conversion LOCATION) `
Needs to be configuration aware. Otherwise if debug and release targets are available it will fall back to `LOCATION_DEBUG` since it is the first available LOCATION and will fail the release build. There could be more than this one which I did not yet discover.
### Steps to Reproduce
Build ITK with having double-conversion release and debug targets available
### Reproducibility
100%
Contributor guide
Assessment
This issue has not been assessed yet.