InseeFrLab / InseeFrLab/s3-operator

s3Instance CRD is not included in the kustomization.yaml

Open
#113 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
66
Forks
16
PR merge metrics
No merged PRs in 30d

Description

Bonjour!

It looks like the [config/default/kustomization.yaml](https://github.com/InseeFrLab/s3-operator/tree/v0.12.0/config/default/kustomization.yaml) references [config/crd/kustomization.yaml](https://github.com/InseeFrLab/s3-operator/tree/v0.12.0/config/crd/kustomization.yaml), but the latter does not include all of the CRDs defined in the [config/crd/bases/](https://github.com/InseeFrLab/s3-operator/tree/v0.12.0/config/crd/bases/) directory (it only omits the `S3Instance` CRD). I can make a PR editing the kustomization, but I can't tell if this is generated by the operator framework or not.

Merci beaucoup :)

---

So far my workaround is to explicitly reference the CRD from my downstream kustomization.yaml:

```yaml
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
- github.com/InseeFrLab/s3-operator/config/default?ref=v0.12.0
- github.com/InseeFrLab/s3-operator/config/prometheus?ref=v0.12.0

# As of v0.12.0 the s3instance CRD is excluded from the
# config/crd/kustomization.yaml template--we have to include it explicitly
- https://raw.githubusercontent.com/InseeFrLab/s3-operator/v0.12.0/config/crd/bases/s3.onyxia.sh_s3instances.yaml

namespace: s3-operator
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.