InseeFrLab / InseeFrLab/pynsee

Improve session management

Open
#148 2 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
89
Forks
14
PR merge metrics
No merged PRs in 30d

Description

Overall ``requests.Session`` objects do not seem to be managed consistently (or sometimes even just properly) throughout the code.
Though I don't think it is likely to lead to severe issues, it could be made cleaner and generally more straightforward to understand if ``with`` statements were used systematically, together with actual benchmarks to see whether this improves performance.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.