InseeFrLab / InseeFrLab/onyxia

My Secrets : a couple of problems with the "Use in a service" buttons

Open
#620 0 comments 2 reactions 1 assignee Claimed by @garronej View on GitHub
Dominant language
TypeScript
Stars
872
Forks
109
Avg merge
6d 3h
Merged PRs (30d)
1

Description

Currently there are two separate buttons for "using a secret" in a service :

- one in the "toolbar" towering the My Secrets space
- when "inside" a given secret, one at the bottom of the screen, next to the *Add a new variable* button

There's at least two differences between the two, one being mostly a nitpick, and the other a bit more serious (although you can circumvent it)

**The nitpick**

Their labels are different, at least in english language (respectively *Use in a service* and *Use in services*)

**The "problem"**

While the "top" button seems to work normally (albeit not saying anything about what it actually does), the other actually shows a modal with some elements :

- a statement *The path of the secret have been copied*
- some instructions on how to use it (which could benefit the top button btw)
- a checkbox *Don't display again*
- a *Got it* button.

But despite the statement, the path is not yet copied at this point, and worse, it's only copied to the clipboard when clicking *Got it* **if the *Don't display again* checkbox is ticked**. If you dismiss the modal by clicking *Got it* without checking the *Don't display again* (which is sane if you want to be able to check the intructions), then nothing happens.

---

I don't have a formal proposition for "fixing" this, but one of the least costly ways could be to :

- have the top button also show the modal, so the two behave similarly
- copy the secret path independently of the *Don't display again* checkbox

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.