InseeFrLab / InseeFrLab/onyxia-ui

Button keeps their 'hover' state when clicked.

Open
#105 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
39
Forks
15
PR merge metrics
No merged PRs in 30d

Description

We should keep MUI default behaviour for hover.
[This PR](https://github.com/InseeFrLab/onyxia-ui/pull/104) was a good temporary patches but it has too many negative side effects.

The real solution is to use a screen scaller that support the use of getBoundingClientRect and other measurement API.
I've started a work toward this: https://github.com/garronej/react-screen-scaler
When we can replace powerhooks's ViewPortProvider with react-screen-scaler all issues related to touch ripple missplacement should go away. It should also solves the misssizing of dropdowns.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.