InseeFr / InseeFr/icarus

Improve syntax of margin input with lists

Open
#8 0 comments 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
R
Stars
12
Forks
7
Avg merge
4d 1h
Merged PRs (30d)
2

Description

The idea is to change the recommended margin input method to something like:

marginList <- list(
"categ" = c(0.35, 0.4, 0.25),
"sexe" = c(0.60, 0.40),
"service" = c(0.45, 0.55),
"salaire" = 470000
)

- Add tests with the list method, with categorical and continuous variables

- Modify addMargin

- marginMatrix becomes an ambiguous parameter name: consider changing it (but ensure retrocompatibility!)

- Change recommended way of integrating margins in the docs

Thanks to Toby Hocking for the suggestion!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.