InseeFr / InseeFr/Lunatic

Inconsistency of `shapeFrom` property type

Open
#1,286 1 comment 0 reactions 1 assignee Claimed by @laurentC35 View on GitHub
Dominant language
TypeScript
Stars
22
Forks
21
Avg merge
9h 13m
Merged PRs (30d)
2

Description

The `"shapeFrom"` property in the model definition `type.source.ts` has inconsistent types: it can be a list at certain places, but only a string in others.

- https://github.com/InseeFr/Lunatic/blob/d64a4bf348f3cbe54544f6863c5d19f404b9227d/src/type.source.ts#L263
- https://github.com/InseeFr/Lunatic/blob/d64a4bf348f3cbe54544f6863c5d19f404b9227d/src/type.source.ts#L290
- https://github.com/InseeFr/Lunatic/blob/d64a4bf348f3cbe54544f6863c5d19f404b9227d/src/type.source.ts#L413

=> To do: figure out which type is adapted and go for it.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.