InseeFr / InseeFr/Keycloak-FranceConnect

[QUESTION] Support for absence of state parameter in logout response

Open
#106 2 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
Java
Stars
106
Forks
39
Avg merge
3d 12h
Merged PRs (30d)
3

Description

Previous version of this plugin had a switch to allow for the absence of the state parameter in franceconnect logout response (for csrf protection)

Shoud we reintroduce this switch in admin panel or should we definitively remove support for accepting logout responses without state parameter ?

It's about code around https://github.com/InseeFr/Keycloak-FranceConnect/blob/master/src/main/java/fr/insee/keycloak/providers/common/AbstractBaseIdentityProvider.java#L202C1-L211C100

Contributor guide

Open the contributing guide

Research direction

Review the logout-response handling in src/main/java/fr/insee/keycloak/providers/common/AbstractBaseIdentityProvider.java around lines 202-211. Determine whether the project should restore an admin-panel switch or remove acceptance of responses without the state parameter; done means the decision and expected behavior are documented clearly enough to implement.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
authentication
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.