InseeFr / InseeFr/Eno

Make early returns in converter classes

Open
#583 1 comment 0 reactions 1 assignee Claimed by @nsenave View on GitHub
Area: Tech State: Standby Type: Feature
Dominant language
Java
Stars
17
Forks
26
PR merge metrics
No merged PRs in 30d

Description

Converter classes should be transformed with conversion annotations (so that the convertion logic would appear directly in the model classes, the current implementation "hides" the logic in some way)

Before this we could yet improve these classes with early returns.

> "else" is devil =) cognitive complexity could be significatively reduced here with early returns

_Originally posted by @davdarras in https://github.com/InseeFr/Eno/pull/573#discussion_r1178799748_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.