InseeFr / InseeFr/Eno

Hard-coded Lunatic labels types

Open
#533 0 comments 0 reactions 0 assignees View on GitHub
implementation discussion Type: Feature
Dominant language
Java
Stars
17
Forks
26
PR merge metrics
No merged PRs in 30d

Description

Lunatic model has introduced complex label objects which have a `String` value (that corresponds to previous label modeling), and a **type**. This type is currently a `String` that should be better modeled later on (https://github.com/InseeFr/Lunatic-Model/issues/72), but it is not the purpose of this issue.

The value of these label types is hard-coded in Eno:
- in [ddi2lunatic-xml-fixed.xsl](https://github.com/InseeFr/Eno/blob/ff20824a2fe7229226468227cdceb10ec09beb30/src/main/resources/xslt/transformations/ddi2lunatic-xml/ddi2lunatic-xml-fixed.xsl#L739) sheet in V2
- in mapping annotations in V3 (https://github.com/InseeFr/Eno/commit/7cb8374a98392661f731a3fce5834ea5978d0438)

This should rather be done either with metadata, or maybe be fixed by [Lunatic-Model](https://github.com/InseeFr/Lunatic-Model). The value of Lunatic label types should not be determined by Eno.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.