InnovativeInventor / InnovativeInventor/docker-pivpn

Does not build ! Wrong docker build command and file/folder existence checks

Open
#6 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
92
Forks
17
PR merge metrics
No merged PRs in 30d

Description

I tried the setup script but I could not build the Dockerfile.

*) The build command is wrong: `docker build -t innovativeinventor/docker-pivpn:$tag $tag/Dockerfile`
it should be `docker build -f $tag/Dockerfile -t innovativeinventor/docker-pivpn:$tag .`

*) The checks for the existence of Dockerfile and `setup_repo() { if [ -e docker-pivpn` are in wrong folders, also the git clone.
I can try to fake that with creating a Dockerfile in the setup.sh folder and a docker-pivpn folder inside.

*) install.sh is called 2 times !

*) the sed --> Default.txt fails, that file is not in that folder

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.