InfiniTimeOrg / InfiniTimeOrg/InfiniTime

Consider refactoring references into template parameters

Open
#2,370 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

maintenance
Dominant language
C
Stars
3.4k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

Verification
  • I searched for similar issues (including closed issues) and found none was relevant.
Introduce the issue

It's possible to incorporate references to static / global variables as template parameters. Instead of building out types like HeartRateTask etc with constructors to local variables, the references could be built directly into the type.

May save a few bytes of stack space.

Preferred solution

No response

Version

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating HeartRateTask and the related task constructors and static or global references. Review how these types are instantiated and determine whether references can be expressed as template parameters without changing behavior. Done means the refactor is implemented consistently and its stack-space impact is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
embedded-iot
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.