InfiniTimeOrg / InfiniTimeOrg/InfiniTime
GCC >= 10 is now required
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 3.4k
- Forks
- 1.1k
- PR merge metrics
- No merged PRs in 30d
Description
Verification
- I searched for similar issues (including closed issues) and found none was relevant.
Introduce the issue
I was compiling InfiniSim (and InfiniTime) on an Ubuntu 20.04 (WSL), which comes with GCC 8 if I'm not mistaken, and ran into a couple of issues with C++20 support. Tried GCC 9 too but kept having the same problem.
This commit introduces the use of consteval (C+++20), but that's only supported by GCC10 onwards.
Preferred solution
It'd be a good idea to make that assumption explicit in the CMake configurations. I'd be happy to place a PR for that if contributions are welcome.
Version
fc5424cb@main
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the CMake configurations and inspect how compiler or C++ standard requirements are currently checked. Make the GCC 10 requirement explicit for the C++20 usage, then configure or build InfiniSim and InfiniTime with an older compiler to verify the requirement is reported clearly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100