InfiniTimeOrg / InfiniTimeOrg/InfiniTime

Short ref doesn't appear in CI builds

Open
#1,842 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C
Stars
3.4k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

Verification
  • I searched for similar bug reports (including closed issues) and found none was relevant.
What happened?

When checking the About or Firmware pages, if running a build from GitHub CI, there will be no short ref

What should happen instead?

There should be one

Reproduction steps
  1. Download and install a release build
  2. Go to the about page and see a commit reference next to short ref (for 1.13, this is 5f3acfad)
  3. Download and install a CI build (this is the 1.13 commit)
  4. Go to the about page and notice a distinct lack of a short ref
Version

v1.13.0

Companion app

Gadgetbridge v0.75.1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the release build and the linked GitHub CI build, then trace the About and Firmware pages to see how the short ref is supplied. Reproduce the difference with both builds and make the short commit reference appear for CI builds as it does for release builds.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, cpp, github-actions
Domain
build-system, embedded-iot
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.