InfiniTimeOrg / InfiniTimeOrg/InfiniTime
Metronome: Dragging the arc will snap to 98 bpm
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 3.4k
- Forks
- 1.1k
- PR merge metrics
- No merged PRs in 30d
Description
Verification
- I searched for similar bug reports and found none was relevant.
What happened?
Dragging the arc will snap to 98 bpm
What should happen instead?
No response
Reproduction steps
This issue happens since this commit https://github.com/InfiniTimeOrg/InfiniTime/commit/5ef3c0d3be58b6741a9e443e6d2151de2b3a59bc.
More details?
In Metronome, we don't want the app to close while dragging the arc. This was previously accomplished by setting the return touch event to none, and handling the exiting in app, but there's currently no way to disable the default return touch event. Returning true in OnTouchEvent will cancel LVGL tap, which will move the cursor to {-1, -1}, which is at the top left corner of the screen, setting the bpm to 98. Returning false will allow DisplayApp to close the app if it detects an appropriate touch event.
Version
develop
Companion app
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing commit 5ef3c0d3be58b6741a9e443e6d2151de2b3a59bc and the Metronome touch handling described in the issue. Trace how DisplayApp and LVGL process the return touch event and verify the behavior by dragging the arc. Done means dragging no longer closes the app or changes the bpm to 98.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100