InfiniTimeOrg / InfiniTimeOrg/InfiniTime

Purpose of MotionController

Open
#1,679 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

maintenance
Dominant language
C
Stars
3.4k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

Verification
  • I searched for similar issues and found none was relevant.
Introduce the issue

What is the purpose of MotionController? We just copy data from the driver to it and add a few functions. Why not use the driver directly?

Preferred solution

Remove/split MotionController and use the driver directly. The trip counter could be another class, maybe the step counter as well.

Version

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating MotionController, the driver it copies from, and the trip and step counter functions. Trace which callers depend on each interface before deciding whether the controller can be removed or split. Done means the responsibilities and replacement interfaces are agreed and all affected callers continue to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
embedded-iot
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.