InfiniTimeOrg / InfiniTimeOrg/InfiniTime

Moving class constructors to SystemTask

Open
#1,493 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

maintenance
Dominant language
C
Stars
3.4k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

Currently everything is constructed in main and passed to both DisplayApp and SystemTask. We could move almost everything, including DisplayApp to SystemTask, to limit their scope. I want your feedback on this before I create a PR, so I won't have to maintain the PR for long.

This relates to #1468, as it shows how the scope of MotorController can be limited for example.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how constructors are assembled in main and passed to DisplayApp and SystemTask. Read issue #1468 for the related MotorController scope example; the work is complete only once the proposed ownership boundaries are agreed and the affected construction flow is consistently updated.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
embedded-iot
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.