Incendo / Incendo/cloud-minecraft

Command literal aliases do not work with Brigadier

Open
#5 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

brigadier
Dominant language
Java
Stars
110
Forks
29
PR merge metrics
No merged PRs in 30d

Description

Aliases of literal arguments do not show up in the command suggestions for Brigadier. The commands do, however, still work if you use the aliases. I had a little chat on the Discord server with a couple of the devs and found that this is intentional due to polluting the Brigadier command node map. I would recommend either documenting that this is intentional somewhere (the wiki perhaps?), or maybe add an option to enable this functionality explicitly since it has downsides.

Example code: https://pastebin.com/71hT3fSW
Gif of executing the command with suggestions: https://gyazo.com/c78e08a403f6e95194e1574167e70990

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the missing Brigadier suggestions with the linked example and inspect the Brigadier integration responsible for command aliases. The issue does not choose between documenting the intentional behavior and adding an opt-in option, so the expected completion criteria require maintainer clarification.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.