Incendo / Incendo/cloud-minecraft-modded

Override existing commands setting does not override redirect commands

Open
#114 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
7
Forks
9
Avg merge
1m
Merged PRs (30d)
1

Description

Running with Cloud 2.0.0-beta.15 (NeoForge)

It appears the OVERRIDE_EXISTING_COMMANDS manager setting isn't working properly for redirect commands.

I have the setting enabled on my manager's settings:

manager = NeoForgeServerCommandManager.createNative(ExecutionCoordinator.simpleCoordinator());
manager.settings()
		.set(ManagerSetting.OVERRIDE_EXISTING_COMMANDS, true);

I have the command annotation:

@Command("message|msg|pm|dm|m|tell|whisper|w <recipient> <message>")

/whisper runs my command properly, but /w and /tell do not (which are both vanilla redirects for /whisper).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at NeoForgeServerCommandManager.createNative and the handling of ManagerSetting.OVERRIDE_EXISTING_COMMANDS, then trace how redirect commands such as /w and /tell are registered versus /whisper. Reproduce the behavior with the shown annotation and consider the issue complete when all aliases override the vanilla redirects.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.