ImperialCollegeLondon / ImperialCollegeLondon/SWMManywhere

Test what happens when you have edges between same start and end nodes

Open
#92 0 comments 0 reactions 0 assignees View on GitHub
testing
Dominant language
Python
Stars
51
Forks
11
PR merge metrics
No merged PRs in 30d

Description

> Is correct that this is a warning and not an error? By construction of the graph object, is it even possible to have two edges with the same u and v? I mean, can you have two edges that connect the same two nodes?

_Originally posted by @dalonsoa in https://github.com/ImperialCollegeLondon/SWMManywhere/pull/83#discussion_r1525790626_

Contributor guide

Open the contributing guide

Research direction

Start with the discussion from PR #83 referenced in the issue, then locate the graph construction and the warning about edges sharing the same start and end nodes. Add coverage for the possible duplicate-edge case and document the expected warning or error behavior; done means the test resolves the open question.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.