ImperialCollegeLondon / ImperialCollegeLondon/SWMManywhere
Accommodate other SWMM objects and variables
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 51
- Forks
- 11
- PR merge metrics
- No merged PRs in 30d
Description
These are hardcoded. That's ok if this is all there is and there won't be any more, but just checking that we don't want to make this changeable.
Originally posted by @dalonsoa in https://github.com/ImperialCollegeLondon/SWMManywhere/pull/58#discussion_r1510983361
Currently we only support Subcatchments, Nodes (as storage type), Links (as circular type) object types.
We also only store information for flooding, depth, flow, runoff.
Future applications may want to expand on both of these fronts - any discussion of that can be kept here
Should be easy to accommodate now with: #84
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by tracing where support for Subcatchments, Nodes, Links, flooding, depth, flow, and runoff is hardcoded, then review issue #84 for the proposed direction. Done means extending both object and variable support without breaking the existing cases, with tests covering them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100