ImperialCollegeLondon / ImperialCollegeLondon/SWMManywhere
Move lanes processing to `preprocessing`
Open
Nobody has claimed this yet.
refactor
- Dominant language
- Python
- Stars
- 51
- Forks
- 11
- PR merge metrics
- No merged PRs in 30d
Description
I am not sure about this ad-hoc solution. I'd suggest solving the issue at its source, i.e., add a new post-processing step for the street graph to ensure that lane's edge attribute is an int.
Originally posted by @cheginit in https://github.com/ImperialCollegeLondon/SWMManywhere/issues/258#issuecomment-2317606843
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. Start by locating the preprocessing flow and street-graph handling for the lane edge attribute; the work is done when a post-processing step ensures that attribute is an integer.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100