Immediate-Mode-UI / Immediate-Mode-UI/Nuklear

Incorrect value returned by nk_font_korean_glyph_ranges

Open
#285 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
11.4k
Forks
686
Avg merge
4d 1h
Merged PRs (30d)
3

Description

I found this small bug while playing with nuklear's font atlas baking:

[On the 111th line of nuklear_font.c](https://github.com/Immediate-Mode-UI/Nuklear/blob/d829ff1ef1e84d4ee46c600d228d1a274923ed07/src/nuklear_font.c#L111), one of the ranges specified as the return value of `nk_font_korean_glyph_ranges` is `0xAC00, 0xD79D`, which supposedly corresponds to the set of Hangul syllables.

However, the end of the range, `0xD79D`, corresponds to the letter `힝`, while the last letter of the set is `0xD7A3`, which is `힣`.
The consequence of this is that 6 Hangul characters `힞힟힠힡힢힣` are omitted from the ranges returned by `nk_font_korean_glyph_ranges`.

This is a tiny bug which is easy to work-around, and 6 affected characters are rarely used, but I decided to report this nevertheless...

Reference: https://en.wikipedia.org/wiki/Hangul_Syllables

Contributor guide

Open the contributing guide

Research direction

Open src/nuklear_font.c at line 111 and inspect the ranges returned by nk_font_korean_glyph_ranges. Verify the Hangul syllable range against the stated endpoints and confirm that the six characters from 힞 through 힣 are included. Done means the returned range covers the complete set through 0xD7A3.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
frontend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.