Immediate-Mode-UI / Immediate-Mode-UI/Nuklear

checkbox behaviour is reversed and wrong

Open
#222 9 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
11.4k
Forks
686
Avg merge
4d 1h
Merged PRs (30d)
3

Description

When the checkbox is active, its square should be coloured and when is inactive it should be uncoloured.

To better illustrate this, consider the following current implementation:

Checkbox active: ![Screenshot from 2021-03-18 09-04-50](https://user-images.githubusercontent.com/19549703/111602112-f0eadf00-87ca-11eb-8769-bfac71fc84f1.png)

Checkbox inactive: ![Screenshot from 2021-03-18 09-05-05](https://user-images.githubusercontent.com/19549703/111602132-f516fc80-87ca-11eb-9c3b-fee6dfc321f2.png)

Currently, IMO this behaviour is reversed and wrong, .i.e., they look to me like the checkbox icons should be reversed.

You can check that behaviour in overview -> Widgets -> Inactive.

Ideally, to avoid confusion, one would want a checkbox that displays sort of a cross when active, like this (with customizable color):

![hhh](https://user-images.githubusercontent.com/19549703/111603111-eb41c900-87cb-11eb-9172-5df6ea6d7045.png)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the current behavior in overview → Widgets → Inactive and compare the active and inactive checkbox appearances with the issue screenshots. Locate the checkbox rendering entry point, then verify that active and inactive states use the intended coloring and that the selected active mark can support a customizable color.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
design, desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.