IjzerenHein / IjzerenHein/react-navigation-shared-element

[v5] android - Source image disappears when going back

Open
#71 11 comments 2 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.3k
Forks
125
PR merge metrics
No merged PRs in 30d

Description

Hello,
First of all thanks for this nice lib 👍
I'm using it with the following versions:
```json
"@react-navigation/native": "^5.3.2",
"@react-navigation/stack": "^5.3.5",
"react-navigation-shared-element": "^5.0.0-alpha1",
"react-native-shared-element": "^0.7.0",
```

It's working well, but I have a small weird bug happening on android. When I press an Icon on top of a shared element to go back, the source element doesn't shows up.

If I press the OS back button, or any element doing a `navigation.goBack` provided this element is not on top of the `SharedElement`, it's working ok.

Here is a screen record:
https://imgur.com/a/mUn8HfU

As you can see, when I click on the red bordered arrow on top the source image of the transition doesn't show up. If I click on the "link" (Voir sur la carte) below the image, the source image shows up. (both Arrow and "link" triggers a `navigation.goBack`)

Any idea?

PS: my `react-native info`:
```
info Fetching system and libraries information...
System:
OS: macOS Mojave 10.14.6
CPU: (8) x64 Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
Memory: 3.90 GB / 16.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 12.14.1 - ~/.nvm/versions/node/v12.14.1/bin/node
Yarn: 1.22.4 - /usr/local/bin/yarn
npm: 6.13.4 - ~/.nvm/versions/node/v12.14.1/bin/npm
Watchman: Not Found
Managers:
CocoaPods: 1.9.1 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
Android SDK: Not Found
IDEs:
Android Studio: 3.6 AI-192.7142.36.36.6241897
Xcode: 11.2.1/11B500 - /usr/bin/xcodebuild
Languages:
Java: 1.8.0_242 - /usr/bin/javac
Python: 2.7.10 - /usr/bin/python
npmPackages:
@react-native-community/cli: Not Found
react: 16.13.1 => 16.13.1
react-native: 0.62.2 => 0.62.2
npmGlobalPackages:
*react-native*: Not Found
```

Contributor guide

No contributing guide indexed for this repository

Research direction

No source files or tests are named. Reproduce the Android transition with the listed React Navigation and React Native versions, comparing the top arrow's navigation.goBack with the link's navigation.goBack; the issue is resolved when the source image appears for both paths.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native, typescript
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.