IjzerenHein / IjzerenHein/react-navigation-shared-element

Native Stack review

Open
#216 0 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
1.3k
Forks
125
PR merge metrics
No merged PRs in 30d

Description

https://github.com/IjzerenHein/react-navigation-shared-element/blob/4713cd80d4d093b1a9d6dd1232984faebf515951/src/native-stack/createSharedElementNativeStackNavigator.tsx#L173

On iOS, we may want to wrap this with `FullOverlayView` from React Native Screens. That way, it will display on top of modals.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/native-stack/createSharedElementNativeStackNavigator.tsx around line 173 and review how the native stack is rendered. Read the React Native Screens documentation for FullOverlayView and check its behavior on iOS when modals are present. Done means the shared element content displays correctly above modals without breaking the native stack.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native, typescript
Domain
mobile-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.