IjzerenHein / IjzerenHein/react-native-shared-element
Can't build on iOS with RN 0.80
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.3k
- Forks
- 113
- PR merge metrics
- No merged PRs in 30d
Description
RNSharedElementCornerRadii gives the error:
node_modules/react-native-shared-element/ios/RNSharedElementCornerRadii.m:77:77 Too few arguments to function call, expected 4, have 3
for this line:
CGPathRef path = RCTPathCreateWithRoundedRect(bounds, cornerInsets, NULL);
it should be:
CGPathRef path = RCTPathCreateWithRoundedRect(bounds, cornerInsets, NULL, NO);
Not like this library is maintained anyway, but if anyone passes by and needs the fix.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open node_modules/react-native-shared-element/ios/RNSharedElementCornerRadii.m and inspect the call at line 77. Update the RCTPathCreateWithRoundedRect invocation to match the four-argument signature shown in the issue, then verify that the library builds on iOS with React Native 0.80.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100