Correct MSSQL quoting
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 4
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Description
IIRC, you're replacing literal [ in [mssql_identifiers] with [[].
Not only this seems unnecessary: https://learn.microsoft.com/en-us/sql/relational-databases/databases/database-identifiers?view=sql-server-ver17#bracket-delimited-identifiers
But what do you do with literal ] in identifiers?
IMAO we should just replace ] with ]] and that's it.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the [mssql_identifiers] implementation and read how bracket-delimited identifiers are escaped. Confirm the desired SQL Server quoting behavior for literal ] characters and update the handling so the issue's requested behavior is covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, sql
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100