Icinga / Icinga/ipl-orm

RewriteFilterBehavior::rewriteCondition() Argument and return type do not match

Open
#45 0 comments 0 reactions 1 assignee View on GitHub

@nilmerg is already working on this.

Since Aug 19, 2022.

bug
Dominant language
PHP
Stars
1
Forks
1
Avg merge
1h 26m
Merged PRs (30d)
1

Description

RewriteFilterBehavior::rewriteCondition() expects Filter\Condition but allows Filter\Rule to be returned. This can also return Chain, such as in FlattenedObjectVars. This breaks any behavior that follows a behavior that returns something other than Filter\Condition, as behaviors are processed sequentially, using the previous behavior's result for the current one.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.