Icinga / Icinga/ipl-orm

`ipl\Orm\Query::assembleSelect()` causes unintended side-effects

Open
#166 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
1
Forks
1
Avg merge
1h 26m
Merged PRs (30d)
1

Description

Build a query similar to this:

Incident::on(Database::get())
    ->with(['object'])
    ->withColumns([
        'object.id_tags',
        'object.source.name',
        'object.source.type'
    ]);

Now ->count() said query and then iterate it.

You'll notice that the iteration now includes columns you didn't ask for.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at ipl\Orm\Query::assembleSelect() and reproduce the example by calling count() before iterating the query. Trace how the selected columns change across those operations; done means iteration returns only the columns requested through withColumns().

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend, database
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.