Form error handling flawed
Open
Nobody has claimed this yet.
bug
- Dominant language
- PHP
- Stars
- 1
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
The current form error handling has the following flaws:
- It swallows exception traces
isValid()is true even if the form has errors- Form error messages can't be styled, i.e. error markup is hardcoded in
Form::onError()
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Begin with Form::onError() and the implementation of isValid(), then trace how exceptions and error markup move through the form handling path. Define tests for the three reported flaws and use them to verify exception traces, validity, and configurable error presentation are all addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100